Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prometheus Receiver] Adding testcase to validate renaming metrics actions #6706

Merged
merged 2 commits into from
Dec 14, 2021
Merged

[Prometheus Receiver] Adding testcase to validate renaming metrics actions #6706

merged 2 commits into from
Dec 14, 2021

Conversation

PaurushGarg
Copy link
Member

Description:

  • Added testcases to validate metrics renaming using relabel.Action for replace, drop, and keep.
  • Current behavior- Renaming metrics using metric_relabel_configs converts metrics to gauge double type.
  • These testcases only cover renaming for gauge and counter metrics. As renaming of histogram and summary leads to undefined behavior.

Link to tracking Issue:
Issue: #6090

@PaurushGarg PaurushGarg requested a review from a team December 11, 2021 00:45
@Aneurysm9 Aneurysm9 added the ready to merge Code review completed; ready to merge by maintainers label Dec 14, 2021
@codeboten codeboten merged commit 173e9ea into open-telemetry:main Dec 14, 2021
@PaurushGarg PaurushGarg mentioned this pull request Dec 15, 2021
Closed
6 tasks
@PaurushGarg PaurushGarg deleted the prom-receiver-test-renaming-metric-2 branch December 18, 2021 05:04
povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib Dec 19, 2022
@bogdandrutu
[chore] remove some deprecate API calls in componenttest (#6706)
0b4bbf5 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@codeboten codeboten codeboten approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

Assignees

@dmitryax dmitryax

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PaurushGarg @anuraaga @codeboten @Aneurysm9 @dmitryax